Format header #1459
Format header #1459
Conversation
Very nice and very useful! |
| * A lambda used to format a column header (its displayed name) when rendering a dataframe to HTML. | ||
| * | ||
| * The lambda runs in the context of [FormattingDsl] and receives the [ColumnWithPath] of the header to format. | ||
| * Return a [CellAttributes] (or `null`) describing CSS you want to apply to the header cell. |
| * Return a [CellAttributes] (or `null`) describing CSS you want to apply to the header cell. | ||
| * | ||
| * Examples: | ||
| * - Center a header: `attr("text-align", "center")` |
| * Examples: | ||
| * - Center a header: `attr("text-align", "center")` | ||
| * - Make it bold: `bold` | ||
| * - Set custom color: `textColor(rgb(10, 10, 10))` |
| // region DataFrame.formatHeader | ||
|
|
||
| /** | ||
| * **Experimental API. It may be changed in the future.** |
There was a problem hiding this comment.
Would it make sense to introduce an Experimental OptIn for this API?
There was a problem hiding this comment.
I believe kdoc note is enough.
| */ | ||
| @Suppress("UNCHECKED_CAST") | ||
| public fun <T, C> HeaderFormatClause<T, C>.with(formatter: HeaderColFormatter<C>): FormattedFrame<T> { | ||
| val selectedPaths = df.getColumnPaths(UnresolvedColumnsPolicy.Skip, columns).toSet() |
There was a problem hiding this comment.
maybe move this to formatHeaderImpl
| val composedHeader: HeaderColFormatter<Any?> = { col -> | ||
| val path = col.path | ||
| // Merge attributes from selected parents | ||
| val parentAttributes = if (path.size > 1) { |
There was a problem hiding this comment.
wait... so you're merging attributes from parents here, but also in html.kt? how does it work?
| if (hf == null) { | ||
| null | ||
| } else { | ||
| // collect attributes from parents |
There was a problem hiding this comment.
you also do this in formatHeader.kt?
| var nestedRowsLimit: Int? = 5, | ||
| var cellContentLimit: Int = 40, | ||
| var cellFormatter: RowColFormatter<*, *>? = null, | ||
| var headerFormatter: HeaderColFormatter<*>? = null, |
There was a problem hiding this comment.
this is a public data class; you're breaking binary compatibility by adding this, especially halfway
There was a problem hiding this comment.
We had the same issue with ParserOptions :/ unfortunately, using data classes in the public api is a bit of a nightmare. Adding a new argument breaks the constructor, componentX(), and copy() function.
Check out ParserOptions for a workaround for this
No description provided.